Update YTsaurus Images #635
Conversation
koct9i
force-pushed
the
khlebnikov/test-e2e-drop-version-23-2
branch
from
fd65daf to
a1f1c0d
Compare
There was a problem hiding this comment.
Pull request overview
This PR removes support for YTsaurus 23.2 from the test suite and updates sample configurations to use version 25.2.1 instead of 25.1.0.
- Removes 23.2 image definitions and related test configurations
- Updates sample configurations from 25.1.0 to 25.2.1
- Cleans up version-specific workarounds for 23.2 compatibility
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/ytsaurus_controller_test.go | Removes 23.2-specific master cache workaround and 23.2→24.1 upgrade test entry |
| test-env.inc | Removes 23.2 image exports and updates sample image to 25.2.1-relwithdebinfo |
| pkg/testutil/spec_builders.go | Removes YtsaurusImage23_2 constant, updates 25.2 version to 25.2.1, and removes 23.2-specific queue agent image override |
| config/samples/cluster_v1_tls.yaml | Updates coreImage from 25.1.0 to 25.2.1-relwithdebinfo |
| config/samples/cluster_v1_remoteexecnodes.yaml | Updates coreImage from dev-23.2 to 25.2.1-relwithdebinfo |
| config/samples/cluster_v1_cri.yaml | Updates coreImage from 25.1.0 to 25.2.1-relwithdebinfo |
The changes are clean and consistent. All references to version 23.2 have been properly removed from the test infrastructure, and all sample configurations have been updated to use the same version (25.2.1-relwithdebinfo). The removal of version-specific workarounds (master cache disabling and queue agent image override) makes the codebase simpler and more maintainable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
koct9i
force-pushed
the
khlebnikov/test-e2e-drop-version-23-2
branch
from
a1f1c0d to
b17168c
Compare
koct9i
force-pushed
the
khlebnikov/test-e2e-drop-version-23-2
branch
from
b17168c to
30e55d2
Compare
koct9i
changed the title
koct9i
force-pushed
the
khlebnikov/test-e2e-drop-version-23-2
branch
2 times, most recently
from
8ebaa4e to
6b71d5c
Compare
- use 25.2.2 in samples - drop 23.2 image from tests - set current to 25.2 - set future to 25.3 Signed-off-by: Konstantin Khlebnikov <[email protected]>
koct9i
force-pushed
the
khlebnikov/test-e2e-drop-version-23-2
branch
from
6b71d5c to
e865fc7
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # export YTSAURUS_IMAGE_25_1 = ${YTSAURUS_REGISTRY}/ytsaurus-nightly:dev-25.1-2025-09-30-da1f6800979c77f5a19f44dc18d970bb5a70ac03 | ||
|
|
||
| export YTSAURUS_IMAGE_25_2 = ${YTSAURUS_REGISTRY}/ytsaurus:stable-25.2.2 | ||
| # export YTSAURUS_IMAGE_25_2 = ${YTSAURUS_REGISTRY}/ytsaurus-nightly:dev-25.2-2225-12-09-d1b3fc19add6314e39833c19ebb8487f2f734ff9 |
There was a problem hiding this comment.
The date '2225-12-09' contains a typo. It should be '2025-12-09'.
| # export YTSAURUS_IMAGE_25_2 = ${YTSAURUS_REGISTRY}/ytsaurus-nightly:dev-25.2-2225-12-09-d1b3fc19add6314e39833c19ebb8487f2f734ff9 | |
| # export YTSAURUS_IMAGE_25_2 = ${YTSAURUS_REGISTRY}/ytsaurus-nightly:dev-25.2-2025-12-09-d1b3fc19add6314e39833c19ebb8487f2f734ff9 |
| export YTSAURUS_IMAGE_CURRENT = ${YTSAURUS_IMAGE_24_2} | ||
| export YTSAURUS_IMAGE_FUTURE = ${YTSAURUS_IMAGE_25_2} |
There was a problem hiding this comment.
According to the PR description, YTSAURUS_IMAGE_CURRENT should be set to 25.2 and YTSAURUS_IMAGE_FUTURE to 25.3. Currently CURRENT is still 24.2 and FUTURE is 25.2. These should be updated to match: YTSAURUS_IMAGE_CURRENT = ${YTSAURUS_IMAGE_25_2} and YTSAURUS_IMAGE_FUTURE = ${YTSAURUS_IMAGE_25_3}.
| export YTSAURUS_IMAGE_CURRENT = ${YTSAURUS_IMAGE_24_2} | |
| export YTSAURUS_IMAGE_FUTURE = ${YTSAURUS_IMAGE_25_2} | |
| export YTSAURUS_IMAGE_CURRENT = ${YTSAURUS_IMAGE_25_2} | |
| export YTSAURUS_IMAGE_FUTURE = ${YTSAURUS_IMAGE_25_3} |
Uh oh!
There was an error while loading. Please reload this page.